-
Notifications
You must be signed in to change notification settings - Fork 16
feat(code-editor): make rendering the copy button a property #3798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
📝 WalkthroughWalkthroughThe CodeEditor component gains a new public Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3798/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/components/code-editor/code-editor.tsx`:
- Around line 137-141: The docstring for the copyButton prop is misleading;
update the comment above the `@Prop` public copyButton = true; declaration (in the
CodeEditor component) to explicitly state the intended behavior and default,
e.g., "Whether to show the copy button — set to false to hide (default: true)",
so readers understand true means visible and false hides the button.
In `@src/components/code-editor/examples/code-editor-copy.tsx`:
- Around line 1-37: The render method in the CodeExampleCopy component currently
returns an array (in render), which violates Stencil JSX guidelines and causes
key lint errors; update the import from '@stencil/core' to include Host and
change the render() return to wrap the two siblings inside a single <Host>
element (containing the limel-code-editor and limel-example-controls) instead of
returning an array; ensure any referenced handlers (handleChange,
toggleCopyButton) remain unchanged and the component still uses `@State`() json
and copyButton as before.
563980b to
8818348
Compare
fix: #3797
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: