feat: Integrate OneTrainer into Windows ROCm Helper [Windows/AMD]#1684
feat: Integrate OneTrainer into Windows ROCm Helper [Windows/AMD]#1684NeuralFault wants to merge 6 commits into
Conversation
- derived from InvokeAI profile. - required bnb TheRock compat wheel, gated to Python 3.12 installs. - triton-windows package install
- Inject IRocmPackageHelper and add Windows ROCm install path via StandardPipInstallProcessAsync + InstallWindowsNativeTorchAsync and OneTrainerWindowsRocmProfile for post-torch args - Inject ROCm launch environment vars via BuildLaunchEnvironment when ShouldApplyWindowsLaunchEnvironment is true - Bump RecommendedPythonVersion to 3.12 for all platforms
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Windows ROCm support for the OneTrainer package. It updates the package factory and OneTrainer class to inject and utilize IRocmPackageHelper, configures recommended Python and Torch versions, handles Windows ROCm-specific installation steps (including custom pip packages like triton and bitsandbytes), and applies the necessary launch environment variables. The review feedback identifies critical typos in the newly added OneTrainerWindowsRocmProfile.cs file—specifically a misspelled namespace (StabilityMatrixc) and casing issues in the Default property definition—which will cause compilation failures and must be resolved.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Adds Windows ROCm installation and launch support to the OneTrainer training package for AMD GPU users on Windows. OneTrainer upstream only supported Linux ROCm via requirements-rocm.txt as there was no Windows-native ROCm path.
This will integrate new installs of OneTrainer with the ROCm Technical Preview ROCm/Pytorch build, default environment variable generation and pass-through by the ROCm helper based on user's hardware, and automatic installation of needed dependencies to match upstream.
Changes:
Default Python version bumped up to 3.12 for new installs on all OS/Hardware platforms, both for Windows/ROCm compatibility and to also modernize the default installs within upstream documentation.