Fix: Normalize macro route path to ensure compatibility with Windows#11
Merged
Merged
Conversation
… so that Axum no longer panics.
Contributor
Author
pacman82
reviewed
Mar 2, 2026
Force CI to restart properly
added 2 commits
March 4, 2026 22:18
Contributor
|
Anything I could help with to move this forward? |
paolobarbolini
approved these changes
Mar 20, 2026
Member
paolobarbolini
left a comment
There was a problem hiding this comment.
Sorry for the delay. A few more improvement ideas around this area of the code came up while reviewing this PR, put we won't make you wait for those to land first. LGTM.
Contributor
|
@paolobarbolini No need to apologize. Thanks for the great work. Looking forward to the release and the other improvements. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue description :
The macro was generating route paths from filesystem paths without normalizing separators/leading slash on Windows, so Axum received paths like \foo and panicked.
Fixes :
All Unit tests are now good on Linux and Windows. (i was not able to test on Mac).