Fix deserialization of AuthenticationMethod#6
Merged
paolobarbolini merged 2 commits intoApr 30, 2026
Conversation
Contributor
Author
|
We have an unrelated |
Member
|
Fixed on |
`serde` triggers an error if none of the fields in the other variants are found, it does not like the _stateless variant form_.
To avoid analogous problems in the future.
dodomorandi
force-pushed
the
fix-authentication-method-none
branch
from
12bf2b6 to
9a4dd7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no authentication methods are provided,
serdeshould create anAuthenticationMethod::Nonevariant. However, in order to do so, the representation of the variant should beNone {}instead ofNone.Added a bunch of regression tests for the deserialization of
FromEnvto prevent regressions.