add newfstatat syscall to seccomp filter for printf compatibility#1
Open
Yin-SHT wants to merge 1 commit intoMATCHA-MIT:masterfrom
Open
add newfstatat syscall to seccomp filter for printf compatibility#1Yin-SHT wants to merge 1 commit intoMATCHA-MIT:masterfrom
Yin-SHT wants to merge 1 commit intoMATCHA-MIT:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a compatibility issue with the seccomp filter that causes the program to crash on systems running glibc 2.33 or newer.
Problem
The current seccomp filter only allows the
fstatsyscall forprintfoperations. However, modern glibc versions (2.33+) have switched to usingnewfstatatinstead offstatfor checking file descriptor properties during stdio operations.When
printfis called on newer systems, it triggersnewfstatat, which is not in the allowed syscall list, causing the process to be killed.Solution
Added
SYS_newfstatatto the seccomp filter's allowed syscall list: