Change cursor icon on hovering over different UI elements#1522
Open
PUFFMON wants to merge 4 commits intoMCLCE:mainfrom
Open
Change cursor icon on hovering over different UI elements#1522PUFFMON wants to merge 4 commits intoMCLCE:mainfrom
PUFFMON wants to merge 4 commits intoMCLCE:mainfrom
Conversation
Author
|
Fixed Button lists not updating the mouse icon. This fix also fixes the How to Play list, |
+ comments to mark this snippet
- Moved the whole icon updater snippet to a new function inside UIController so it can be called outside tickInput. - Made a new variable inside tickInput function for the same reason. - Modified SetCursorIcon inside KeyboardMouseInput so it gets the current icon instead of reloading the cursor.
Author
|
This PR should be feature complete. It needs some testing to make sure no errors happen and then it should be ready for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When playing using keyboard and Mouse, the mouse cursor's icon will change depending on what UI element is hovering on:
IDC_HAND.IDC_IBEAM.IDC_SIZEWE.IDC_NO.IDC_ARROW.Changes
Previous Behavior
The cursor always used the Arrow icon.
Root Cause
The behaviour wasn't programmed.
Fix Implementation
I added a new function inside KeyboardAndMouseInput script that changes the icon of the cursor. This function is called in UIController.cpp inside tickInput.
AI Use Disclosure
No AI was used
Current known issues