fulmine: 5.11.0, and /pipeline written so it compiles - #1117
Merged
Conversation
nigrosimone
marked this pull request as ready for review
August 14, 2026 06:01
nigrosimone
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
August 14, 2026 06:01
Contributor
Author
|
benchmark -f fulmine --save |
Owner
|
/benchmark -f fulmine --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
MDA2AV
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fulmine.js 5.11.0, and one change to the entry.
/pipelinewas going through the ordinary router rather than through the declarative response this entry's README claims for it. The compiler reads the handler's source and cannot see into a closure, sores.set(SERVER_HDR)kept it off that path. Written out as a literal it is compiled at listen() and answered by uWS without entering JavaScript.Standard mode as before: the same documented APIs, no new setting, and nothing the entry precomputes itself. If you read a compiled handler as a pre-computed response body under the workload rules, say so and I will put it back.
5.11.0 also gives a compiled route a Content-Length, so its framing now matches Express, and it is what the entry runs with.