Backport change from main to a new release branch#935
Backport change from main to a new release branch#935VincentVanlaer wants to merge 38 commits intor25.12.1_colors_updatedfrom
Conversation
Older link is stale, use newer permalink provided by site
* [ci skip] minor change to python helper so different filters work. * [ci skip] readme updates, still WIP * [ci skip] new python visualisations for interpolation distance * added interpolation radius to allow for quality checks in custom colors + added select case for those wishing to change interpolation method -- this still needs to be piped to a user option * [ci skip] updating python helpers now so later commit is easier * [ci skip] added zero point defined by user] * [ci skip] added user defined zero point * [ci skip] updating colors data file * [ci skip] WIP README, new format and overview. * [ci skip] changed defaults to Johnson UBVRI * readme update * [ci skip] pulling updates * [ci skip] Update distance value in colors.defaults to 10pc * [ci skip] cleaning * [ci skip] pg star * [ci skip] inlists * [ci skip] updated defaults * [ci skip] make_CMD_InterpRad_movie.py * Update README.rst * Update README.rst * [ci skip] Enhance README with parameter examples Added examples for various parameters in README. * [ci skip] added management for missing columns in stellar atm tables * [ci skip] inlist update * Update README.rst * Enhance README with test suite details and usage Expanded the README to include detailed descriptions of the test suite's functionality, output, and purpose. Added sections on real-time visualization and inlist options. * Create README.rst * [ci skip] removed old python helpers from /colors/ as they are now deprecated with https://github.com/nialljmiller/SED_Tools * cleaning for merge * lintinh * adding new colors data * fortitude check --fix * ruff check on python files * added some pg star windows * change colors test termination condition * make sure to save final.mod in colors testing * add final modl name * fixing bug found in usage of clight where the wrong units were assumed for AB zeropoint. Also fixed Vega zero point interpolation error. * [ci skip] cleaning files * built with SDK 25.12.1 * moved colors data from colors/data to data/colors_data * [ci skip] Added more files for moving the data. * [ci skip] removing junk * [ci skip] removing file io junk * [ci skip] updates on file io operations. zero points are calculated at initilisation and SED tables are cached at initialiation. * [ci skip] updates for history files and python helpers * fixed inlist * Python linting * Python linting * Apply suggestions from code review removing unnecessary redefine of dp. Co-authored-by: Warrick Ball <W.H.Ball@bham.ac.uk> * [ci skip] docs linting --------- Co-authored-by: pmocz <philip.mocz@gmail.com> Co-authored-by: Warrick Ball <W.H.Ball@bham.ac.uk>
Allocate flux_cube_lambda for trilinear interpolation and update boundary checks to use lbound and ubound functions instead of assuming a 1 base index.
The omp simd directive assumes that all loop iterations are independent. This is not the case for swapping elements of a single row/column. Hence, this causes UB.
Changing names on MAC
Changing MRP names
VincentVanlaer
requested review from
Debraheem,
fxt44,
mjoyceGR,
rhdtownsend and
rsmolec
as code owners
|
Should the release number follow the year-month-number approach we've been using previously -- e.g., 26.3.1 for the first release in March 2026? |
|
I agree, this’ll be a full blown release, not just a patch of an old one. |
|
It introduces/bolsters important capabilities in a real way — I also think it should be a “full” release with a March/april timestamp. Plus, it contains changes that have happened since December. On Mar 22, 2026, at 1:56 PM, Matthias Fabry ***@***.***> wrote:matthiasfabry left a comment (MESAHub/mesa#935)
I agree, this’ll be a full blown release, not just a patch of an old one.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Since this is shaping up to be a full release, I've updated the controls documentation by moving the new tdc controls from controls_dev into the controls.defaults. This is purely a documentation change. A separate pr will handle the merge into main. |
…DC module. Updated changelog for version 26.3.1, including new features in the TDC module.
|
I've amended the changelog with the new release version name "26.3.1", and documentation for the tdc changes. |
|
@nialljmiller @VincentVanlaer, aside from testing, is there anything else we need to add into this branch before merging and beginning the release process? |
|
Can we add a build check using SDK 26.3.2? This may require @matteocantiello to put together a Zenodo release for the SDK. |
@Debraheem Two things would still need to happen. #926 needs to be merged (I wanted to do this earlier, but didn't find the time to properly test stellar) and the colors changes in #929 that are not the Newton iterations need to split out. Both of these can happen after this branch merges in however.
@rhdtownsend Should be possible with just the SDK being on your website. I have also done some tests myself and it seems to work fine. But both of those would just be Linux tests. |
The colors changes in #929 that aren't the Newton iterations still need to be split out. But that can happen after this branch merges, so it's not a blocker. I will do that once #935 is in. |
9 participants
This contains:
Please comment if you think certain changes should be in the small release. I have named the release 25.12.2 in the changelog but this can of course be changed.