add heterodyne functionality to aframe#440
Merged
Merged
Conversation
wbenoit26
requested changes
Apr 13, 2026
Contributor
wbenoit26
left a comment
wbenoit26
left a comment
There was a problem hiding this comment.
Mostly looks great, just a few comments.
| chirp_mass_spacing (Literal["linear", "log"]): | ||
| Spacing of chirp mass grid. Use "linear" for evenly spaced | ||
| values or "log" for logarithmic spacing. | ||
| keep_last_n_seconds (float): |
Contributor
There was a problem hiding this comment.
I think it would be more intuitive to have this be an optional parameter that defaults to None, with None meaning that the full kernel length is kept.
| def build_transforms(self, *args, **kwargs): | ||
| super().build_transforms(*args, **kwargs) | ||
| self.heterodyne_transform = Heterodyne( | ||
| sample_rate=int(self.hparams.sample_rate), |
Contributor
There was a problem hiding this comment.
Why do these need to be cast to int? In particular, kernel_length is often a float.
EthanMarx
reviewed
Apr 13, 2026
wbenoit26
approved these changes
Apr 17, 2026
bhgupta20
changed the title
heterodyne functionality to aframeheterodyne functionality to aframe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
heterodynefunctionality to thetrainandexportmodules to run in the fullaframesetup.