Repository navigation
feat(dfns): say which model's grid a cellid refers to - #385
Merged
Merged
Conversation
Make Array.cellid value-carrying, as index already is: true for the component's own model's grid, "1"/"2" for the first/second model of the enclosing context (EXGMNAMEA/EXGMNAMEB under an exchange). Strings, not ints, since True == 1; StrictBool so an int is rejected, not coerced. The migration sets cellidm1/cellidm2 on the exg-* components and cellidn/cellidm/cellidsj on gwf-gnc (1, 2, 1), as MF6 hard-codes. An exchange's cellids must name a model, and a row may not mix true with "1"/"2", union arms included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
Array.cellidto signal not only that an array is a cell ID but which model it refers to. Accepttrue/"1"/"2", wheretruemeans the component's own model, and ``"1"/"2"` the first/second model of some enclosing context (e.g. `EXGMNAMEA`/`EXGMNAMEB` for an exchange).