Repository navigation
fix(dfns): fix io roundtrip info loss - #386
Merged
Merged
Conversation
Writing the current schema and loading it back lost two things: * a list item's name: names are stripped since the dict key supplies them, but an item is keyed by `item`, not its name, so it loaded with the list's name (e.g. gwf-oc output_record -> output). Always keep it. * tuple defaults: TOML/JSON/YAML have no tuples, so sim-tdis perioddata's default came back as a list. Freeze list defaults to tuples on load. Add a test that the migrated corpus loads back identical, in each format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
changed the title
wpbonelli
marked this pull request as ready for review
October 8, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing the current schema and loading it back lost two things:
Fix it