Skip to content

fix(cli): fix mf sync - #387

Merged
wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:fix-mf-sync
Oct 9, 2026
Merged

wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:fix-mf-sync

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

sync_dfns no longer exists and the error was swallowed

mf sync imported sync_dfns, which no longer exists, so the DFN sync always
failed. The error was printed and swallowed, and the command exited 0 even
when model sources failed too. Sync each RemoteDfnRegistry from the default
config, and exit 1 if any DFN or model source fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wpbonelli wpbonelli added this to the 1.10.0 milestone Oct 9, 2026
@wpbonelli wpbonelli added the bug Something isn't working label Oct 9, 2026
@wpbonelli
wpbonelli marked this pull request as ready for review October 9, 2026 12:40
@wpbonelli
wpbonelli merged commit 780ee93 into MODFLOW-ORG:develop Oct 9, 2026
16 checks passed
@wpbonelli
wpbonelli deleted the fix-mf-sync branch October 9, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant