Registry allocates surface arrays based on new sfclayer package not PBL choice#1460
Open
dudhia wants to merge 1 commit into
Open
Registry allocates surface arrays based on new sfclayer package not PBL choice#1460dudhia wants to merge 1 commit into
dudhia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the LES options are run in real-data cases, the sfclayer physics is used but not the PBL physics.
Many (over 30) 2d arrays were allocated based on PBL packages when their true dependence is on the sfclayer package.
This caused a failure due to using unallocated arrays.
The fix is to create and use instead a sfclayer package in the Registry.
(Note: in development code PBL was on in namelist to enable these arrays but by-passed for LES options,
now we need PBL to be off when LES is chosen which could require a safety check).
This enables real-data LES applications to run.