Skip to content

Fix footer to match mume.org styling and content#12

Merged
nschimme merged 2 commits intoMUME:masterfrom
nschimme:fix-footer-styling-12606661870621705117
May 5, 2026
Merged

Fix footer to match mume.org styling and content#12
nschimme merged 2 commits intoMUME:masterfrom
nschimme:fix-footer-styling-12606661870621705117

Conversation

@nschimme
Copy link
Copy Markdown
Contributor

@nschimme nschimme commented May 5, 2026

  • Consolidate footer HTML into a single block with
    tags for tighter spacing
  • Update maintenance text to credit the Community and link to Github
  • Remove logo attribution block
  • Adjust CSS for icon grouping and font size consistency
  • Remove unused footer image imports

Summary by Sourcery

Align the docs site footer with mume.org by consolidating its content and updating styling and attribution.

Enhancements:

  • Simplify the footer markup into a single compact block with inline links and line breaks for spacing.
  • Update footer attribution to credit the Community, link to GitHub, and remove the logo attribution section.
  • Adjust footer icon padding and text color for consistent styling with the main site.

- Consolidate footer HTML into a single block with <br> tags for tighter spacing
- Update maintenance text to credit the Community and link to Github
- Remove logo attribution block
- Adjust CSS for icon grouping and font size consistency
- Remove unused footer image imports
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the VitePress footer markup and styling to match mume.org by consolidating the HTML into a single text block with inline icons, updating the maintenance text and credits, removing logo attribution and unused images, and tweaking CSS for footer color and icon spacing.

Flow diagram for consolidated footer markup and styling

flowchart LR
  A_Icons_and_text_inline --> B_Single_footer_block
  B_Single_footer_block --> C_RSS_icon_link
  B_Single_footer_block --> D_Facebook_icon_link
  B_Single_footer_block --> E_Mud_Connector_link
  B_Single_footer_block --> F_Community_and_Valar_maintenance_text
  B_Single_footer_block --> G_Github_maintenance_link
  B_Single_footer_block --> H_HEIG_VD_hosting_text

  style A_Icons_and_text_inline fill:#eef,stroke:#333
  style B_Single_footer_block fill:#eef,stroke:#333

  subgraph CSS_changes
    I_Footer_text_color_darkgrey
    J_Icon_padding_left_only
  end

  B_Single_footer_block --> CSS_changes
  I_Footer_text_color_darkgrey --> B_Single_footer_block
  J_Icon_padding_left_only --> C_RSS_icon_link
  J_Icon_padding_left_only --> D_Facebook_icon_link
Loading

File-Level Changes

Change Details Files
Consolidate and update footer HTML content to match mume.org, including revised maintenance text and removal of logo attribution block.
  • Replace multiple paragraph and aside elements in the footer with a single inline text block separated by
    tags.
  • Keep RSS and Facebook icons but move them inline before the call-to-action text.
  • Update maintenance text to credit the Community and Valar and add a link to the Github repository.
  • Remove the logo attribution aside and related references to specific artwork images.
docs/.vitepress/theme/Layout.vue
Adjust footer styling for consistent color and icon spacing, and remove unused footer image imports.
  • Set a base text color on the .footer element to dark grey to match link styling.
  • Adjust icon padding so only left padding is applied, improving grouping/spacing.
  • Remove unused imports for footer-related Gandalf and Horseman images from the layout component.
docs/.vitepress/theme/Layout.vue
docs/.vitepress/theme/mume.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Using <br> tags for structural separation in the footer reduces semantic clarity; consider keeping paragraph or list markup so screen readers and responsive layouts can better interpret the content.
  • Now that the RSS and Facebook icons are inline with text, you may want to wrap them (and possibly the surrounding text) in a container or use flexbox to ensure consistent alignment and spacing at different viewport widths instead of relying solely on inline flow and <br> breaks.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Using `<br>` tags for structural separation in the footer reduces semantic clarity; consider keeping paragraph or list markup so screen readers and responsive layouts can better interpret the content.
- Now that the RSS and Facebook icons are inline with text, you may want to wrap them (and possibly the surrounding text) in a container or use flexbox to ensure consistent alignment and spacing at different viewport widths instead of relying solely on inline flow and `<br>` breaks.

## Individual Comments

### Comment 1
<location path="docs/.vitepress/theme/Layout.vue" line_range="148" />
<code_context>
+        Do you like MUME? Tell others on
+        <a href="https://www.mudconnect.com/cgi-bin/search.cgi?mode=mud_listing&mud=MUME+-+Multi+Users+In+Middle+Earth" target="_blank" rel="noopener">The Mud Connector</a>.
+        <br>
+        Web site maintained by the Community and the <a href="https://mume.org/about/ainur">Valar</a> on <a href="https://github.com/mume/mume.github.io">Github</a>.
+        Last updated {{ lastUpdated }}.
+        <br>
</code_context>
<issue_to_address>
**nitpick (typo):** Use the correct capitalization for the GitHub brand name.

Please update the link text to `GitHub` to match the official brand spelling and stay consistent with the rest of the site.

```suggestion
        Web site maintained by the Community and the <a href="https://mume.org/about/ainur">Valar</a> on <a href="https://github.com/mume/mume.github.io">GitHub</a>.
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread docs/.vitepress/theme/Layout.vue Outdated
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@nschimme nschimme merged commit 3180b33 into MUME:master May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant