Fix footer to match mume.org styling and content#12
Merged
nschimme merged 2 commits intoMUME:masterfrom May 5, 2026
Merged
Conversation
- Consolidate footer HTML into a single block with <br> tags for tighter spacing - Update maintenance text to credit the Community and link to Github - Remove logo attribution block - Adjust CSS for icon grouping and font size consistency - Remove unused footer image imports
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the VitePress footer markup and styling to match mume.org by consolidating the HTML into a single text block with inline icons, updating the maintenance text and credits, removing logo attribution and unused images, and tweaking CSS for footer color and icon spacing. Flow diagram for consolidated footer markup and stylingflowchart LR
A_Icons_and_text_inline --> B_Single_footer_block
B_Single_footer_block --> C_RSS_icon_link
B_Single_footer_block --> D_Facebook_icon_link
B_Single_footer_block --> E_Mud_Connector_link
B_Single_footer_block --> F_Community_and_Valar_maintenance_text
B_Single_footer_block --> G_Github_maintenance_link
B_Single_footer_block --> H_HEIG_VD_hosting_text
style A_Icons_and_text_inline fill:#eef,stroke:#333
style B_Single_footer_block fill:#eef,stroke:#333
subgraph CSS_changes
I_Footer_text_color_darkgrey
J_Icon_padding_left_only
end
B_Single_footer_block --> CSS_changes
I_Footer_text_color_darkgrey --> B_Single_footer_block
J_Icon_padding_left_only --> C_RSS_icon_link
J_Icon_padding_left_only --> D_Facebook_icon_link
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Using
<br>tags for structural separation in the footer reduces semantic clarity; consider keeping paragraph or list markup so screen readers and responsive layouts can better interpret the content. - Now that the RSS and Facebook icons are inline with text, you may want to wrap them (and possibly the surrounding text) in a container or use flexbox to ensure consistent alignment and spacing at different viewport widths instead of relying solely on inline flow and
<br>breaks.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `<br>` tags for structural separation in the footer reduces semantic clarity; consider keeping paragraph or list markup so screen readers and responsive layouts can better interpret the content.
- Now that the RSS and Facebook icons are inline with text, you may want to wrap them (and possibly the surrounding text) in a container or use flexbox to ensure consistent alignment and spacing at different viewport widths instead of relying solely on inline flow and `<br>` breaks.
## Individual Comments
### Comment 1
<location path="docs/.vitepress/theme/Layout.vue" line_range="148" />
<code_context>
+ Do you like MUME? Tell others on
+ <a href="https://www.mudconnect.com/cgi-bin/search.cgi?mode=mud_listing&mud=MUME+-+Multi+Users+In+Middle+Earth" target="_blank" rel="noopener">The Mud Connector</a>.
+ <br>
+ Web site maintained by the Community and the <a href="https://mume.org/about/ainur">Valar</a> on <a href="https://github.com/mume/mume.github.io">Github</a>.
+ Last updated {{ lastUpdated }}.
+ <br>
</code_context>
<issue_to_address>
**nitpick (typo):** Use the correct capitalization for the GitHub brand name.
Please update the link text to `GitHub` to match the official brand spelling and stay consistent with the rest of the site.
```suggestion
Web site maintained by the Community and the <a href="https://mume.org/about/ainur">Valar</a> on <a href="https://github.com/mume/mume.github.io">GitHub</a>.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tags for tighter spacing
Summary by Sourcery
Align the docs site footer with mume.org by consolidating its content and updating styling and attribution.
Enhancements: