Skip to content

Changes to Mume IV Estonian Magazine page#22

Merged
nschimme merged 19 commits into
MUME:mainfrom
Sunnyl75:main
May 12, 2026
Merged

Changes to Mume IV Estonian Magazine page#22
nschimme merged 19 commits into
MUME:mainfrom
Sunnyl75:main

Conversation

@Sunnyl75
Copy link
Copy Markdown
Contributor

@Sunnyl75 Sunnyl75 commented May 8, 2026

Description

Related Issue

Checklist

  • Wiki Rules: I have followed the Content Rules (mortal knowledge only) and Spoiler Rules (using ::: details Spoiler) as defined in the Contributing Guide.
  • Content Accuracy: I have verified the information added/changed is accurate to the game.
  • Visual Check: I have verified that the page renders correctly (no broken tables, lists, or styling).
  • Local Build: (For coders) Ran docker compose up --build wiki (or npm run docs:build) and verified changes locally.
  • Index Pages: Updated top-level index pages (e.g., docs/guides.md, docs/classes.md) if a major new page was added.

Summary by Sourcery

Update the MUME IV Estonian magazine page with additional magazine scans and expanded gameplay terminology explanations.

Documentation:

  • Embed additional .exe magazine page scans into the MUME IV Estonian magazine article to illustrate the original publication.
  • Expand the in-page explanation of PRAC time and basic combat commands to better guide new players.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 8, 2026

Reviewer's Guide

Adds magazine scan images to the MUME IV Estonian magazine page and expands the core terminology section with more detailed explanations of PRAC/PRAC TIME and basic combat commands.

Flow diagram for basic combat interaction using updated Fighting section

flowchart TD
  A[Encounter enemy] --> B[CONSIDER enemy]
  B --> C{Result acceptable?}
  C -- No --> D[Decide not to attack<br/>or seek help]
  C -- Yes --> E[LOOK enemy]
  E --> F[Decide to attack]
  F --> G[KILL enemy]
  G --> H[Automatic combat rounds<br/>every 0.5 seconds]
  H --> I{Situation hopeless?}
  I -- No --> H
  I -- Yes --> J[FLEE]
  J --> K[Escape with risk of<br/>free hits from multiple enemies]
Loading

File-Level Changes

Change Details Files
Embed additional magazine page scans into the article at relevant sections.
  • Insert an image of .exe magazine page 51 after the podcast discussion section.
  • Insert an image of .exe magazine pages 60-61 after the world description paragraph.
  • Insert an image of .exe magazine pages 62-63 after the expanded core terminology and combat explanation section.
docs/pages/MUME_IV_as_described_in_Estonia.md
Expand and refine gameplay terminology explanations for practice time and combat.
  • Rewrite the PRAC / PRAC TIME definition to be more descriptive, including an explicit example command line and explanation of how pracs improve skills.
  • Add a new subsection explaining basic fighting flow, including CONSIDER, LOOK, KILL, automatic combat rounds, and FLEE, with example commands.
  • Add a small formatting tweak (blank line) before the Buffer definition for readability.
docs/pages/MUME_IV_as_described_in_Estonia.md
Minor formatting fix at the end of the file.
  • Ensure the file ends with a newline after the image credit line to satisfy formatting conventions.
docs/pages/MUME_IV_as_described_in_Estonia.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The alt text for the first added image says 'page 51' while the filename ends in 'Page-59.jpg'; consider aligning the alt text with the actual page number to avoid confusion for readers and screen readers.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The alt text for the first added image says 'page 51' while the filename ends in 'Page-59.jpg'; consider aligning the alt text with the actual page number to avoid confusion for readers and screen readers.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Corrected image file name casing in markdown.
Updated image paths in the documentation to use the correct directory.
Sunnyl75 added 2 commits May 13, 2026 08:42
Updated image paths in the documentation to reflect the correct directory structure.
Removed an image reference from the documentation.
@nschimme nschimme merged commit 18647bd into MUME:main May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants