Skip to content

DW Master Tree Finishup#786

Draft
ze-dom wants to merge 29 commits into
MUnique:masterfrom
ze-dom:DW_master_tree_finishup
Draft

DW Master Tree Finishup#786
ze-dom wants to merge 29 commits into
MUnique:masterfrom
ze-dom:DW_master_tree_finishup

Conversation

@ze-dom
Copy link
Copy Markdown
Contributor

@ze-dom ze-dom commented May 28, 2026

To-do

  • Comment changes with sources
  • UpdatePlugin

Developments

  • MagicEffectCancelHandlerPlugIn to handle cancel magic/skill packets
  • Added Expansion of Wizardry (wiz enhance) strengthener and mastery effects

Bugfixes

  • Expansion of Wizardry magic effect power up values

Copy link
Copy Markdown
Contributor Author

@ze-dom ze-dom May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minWizDmgPerEnergy.InputAttribute = Stats.TotalEnergy.GetPersistent(this.GameConfiguration);
minWizDmgPerEnergy.InputOperator = InputOperator.Multiply;
minWizDmgPerEnergy.InputOperand = 0.2f / 9; // 45 energy adds 1 min wiz damage
minWizDmgPowerUp.Boost.RelatedValues.Add(minWizDmgPerEnergy);
Copy link
Copy Markdown
Contributor Author

@ze-dom ze-dom May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emu

It actually seems to be an added value and not a multiplier (at least for S6-7):
ObjUseSkill: zTeamS6.3, emu
Buffeffect.cpp: zTeamS6.3, emu

Comment on lines +65 to +70
var maxDmgPowerUp = this.Context.CreateNew<PowerUpDefinition>();
magicEffect.PowerUpDefinitions.Add(maxDmgPowerUp);
maxDmgPowerUp.TargetAttribute = Stats.MaximumWizBaseDmg.GetPersistent(this.GameConfiguration);
maxDmgPowerUp.Boost = this.Context.CreateNew<PowerUpDefinitionValue>();
maxDmgPowerUp.Boost.ConstantValue.Value = 1f;
maxDmgPowerUp.Boost.ConstantValue.AggregateType = AggregateType.Multiplicate;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +65 to +68
var critChancePowerUp = this.Context.CreateNew<PowerUpDefinition>();
magicEffect.PowerUpDefinitions.Add(critChancePowerUp);
critChancePowerUp.TargetAttribute = Stats.CriticalDamageChance.GetPersistent(this.GameConfiguration);
critChancePowerUp.Boost = this.Context.CreateNew<PowerUpDefinitionValue>();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant