Skip to content

Feature: item search#790

Open
eduardosmaniotto wants to merge 3 commits into
MUnique:masterfrom
eduardosmaniotto:feature/item-search
Open

Feature: item search#790
eduardosmaniotto wants to merge 3 commits into
MUnique:masterfrom
eduardosmaniotto:feature/item-search

Conversation

@eduardosmaniotto
Copy link
Copy Markdown
Contributor

@eduardosmaniotto eduardosmaniotto commented May 31, 2026

Adds a filterable search input to ItemTable, which renders every collection
property (e.g. PossibleItems, Skills, BasePowerUpAttributes). The search
filters items by name, matching the same pattern already used in AutoForm.

admin.webm

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a search feature to the ItemTable component, enhancing usability for large collections. It includes logic to dynamically filter items based on user input and ensures the search interface is only presented when the item count justifies it, maintaining a clean UI.

Highlights

  • Search Functionality: Added a filterable search input to the ItemTable component to allow users to quickly find items by name.
  • Conditional Search Display: Implemented a search threshold logic where the search bar only appears if the number of items exceeds 10.
  • Style Refactoring: Moved search group styles from a component-specific CSS file to a shared SCSS file for better maintainability.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a search feature to the ItemTable component, allowing users to filter items by name when the item count exceeds a threshold of 10. The styling for the search group has also been refactored into shared stylesheets. Feedback on the changes highlights three key areas for improvement: resolving a bug in OnParametersSet where _showSearch is not reset to false if the collection size decreases, preventing a potential NullReferenceException in the filtering logic when GetName() returns null, and removing a hardcoded HTML id on the search input to avoid duplicate IDs across multiple component instances.

Comment thread src/Web/Shared/Components/Form/ItemTable.razor.cs Outdated
Comment thread src/Web/Shared/Components/Form/ItemTable.razor.cs Outdated
Comment thread src/Web/Shared/Components/Form/ItemTable.razor Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant