fix(weather): reorder daily forecast columns#4118
Open
MannXo wants to merge 2 commits intoMagicMirrorOrg:developfrom
Open
fix(weather): reorder daily forecast columns#4118MannXo wants to merge 2 commits intoMagicMirrorOrg:developfrom
MannXo wants to merge 2 commits intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
Thanks for the PR! Can you attach a before and after screenshot? |
Collaborator
|
I am not sure if changing the order is a good idea. Our users are used to how this is ordered now, changing it might confuse some... But I am willing to see the change in screenshots, before making up my mind finally... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily forecast currently shows columns in this order: condition, max temp, min temp, precip amount, precip probability, UV Index. This is inconsistent with the order requested in the issue.
This PR reorders the daily forecast columns to: condition, min temp (low), max temp (high), UV Index, precip amount, precip probability.
min-tempbeforemax-temp(low before high, per [Change Request] Weather forecast: Low before High Temperature #4116)forecast.njktouched;hourly.njkandcurrent.njkare unchangednode --run lint:prettierpassesFixes #4117