Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion js/http_fetcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,9 @@ class HTTPFetcher extends EventEmitter {
signal: controller.signal
});

if (!response.ok) {
const isSuccessfulResponse = response.ok || response.status === 304;

if (!isSuccessfulResponse) {
const { delay, errorInfo } = this.#getDelayForResponse(response);
nextDelay = delay;
this.emit("error", errorInfo);
Expand Down
25 changes: 25 additions & 0 deletions tests/unit/functions/http_fetcher_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,31 @@ describe("HTTPFetcher", () => {
expect(text).toBe(responseData);
});

it("should treat 304 responses as successful and reset error counters", async () => {
server.use(
http.get(TEST_URL, () => {
return new HttpResponse(null, { status: 304 });
})
);

fetcher = new HTTPFetcher(TEST_URL, { reloadInterval: 60000 });
fetcher.serverErrorCount = 2;
fetcher.networkErrorCount = 3;

const responsePromise = new Promise((resolve) => {
fetcher.on("response", (response) => {
resolve(response);
});
});

fetcher.startPeriodicFetch();
const response = await responsePromise;

expect(response.status).toBe(304);
expect(fetcher.serverErrorCount).toBe(0);
expect(fetcher.networkErrorCount).toBe(0);
});

it("should emit error event on network failure", async () => {
server.use(
http.get(TEST_URL, () => {
Expand Down