Skip to content

Removed coercion errors in latest dependency versions. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kerilk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed coercion errors in latest dependency versions. #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mtg_sdk/representers/card_representer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ module CardRepresenter
property :hand
property :life
property :reserved
property :release_date, as: :releaseDate, type: Date
property :release_date, as: :releaseDate, type: Types::Params::Date
property :starter
property :original_text, as: :originalText
property :original_type, as: :originalType
Expand Down
4 changes: 2 additions & 2 deletions lib/mtg_sdk/representers/changelog_representer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ module ChangelogRepresenter
include Roar::JSON
include Roar::Coercion

property :release_date, as: :releaseDate, type: Date
property :release_date, as: :releaseDate, type: Types::Params::Date
property :version
property :details
end
end
end
4 changes: 2 additions & 2 deletions lib/mtg_sdk/representers/ruling_representer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module RulingRepresenter
include Roar::JSON
include Roar::Coercion

property :date, type: Date
property :date, type: Types::Params::Date
property :text
end
end
end
6 changes: 4 additions & 2 deletions lib/mtg_sdk/representers/set_representer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
require 'roar/json'
require 'roar/coercion'

module MTG
module SetRepresenter
include Roar::JSON
include Roar::Coercion

property :code
property :name
Expand All @@ -13,10 +15,10 @@ module SetRepresenter
property :block
property :old_code, as: :oldCode
property :online_only, as: :onlineOnly
property :release_date, as: :releaseDate
property :release_date, as: :releaseDate, type: Types::Params::Date
property :gatherer_code, as: :gatherCode
property :magic_cards_info_code, as: :magicCardsInfoCode

collection :booster
end
end
end
1 change: 1 addition & 0 deletions mtg_sdk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,5 @@ Gem::Specification.new do |spec|
spec.add_dependency "multi_xml", "~> 0.5"
spec.add_dependency "faraday_middleware", "~> 0.10"
spec.add_dependency "virtus", "~> 1.0"
spec.add_dependency "dry-types", "~> 1.5"
end