Skip to content

chore: add codeowners file#217

Merged
Apricot-S merged 2 commits intomasterfrom
add-codeowners
Feb 20, 2026
Merged

chore: add codeowners file#217
Apricot-S merged 2 commits intomasterfrom
add-codeowners

Conversation

@Nihisil
Copy link
Contributor

@Nihisil Nihisil commented Feb 20, 2026

it will automatically assign us on PRs as reviewers, the file sorted alphabetically

@Nihisil Nihisil added this to the v2.0.0 milestone Feb 20, 2026
@Nihisil Nihisil requested a review from Apricot-S February 20, 2026 01:48
Copy link
Collaborator

@Apricot-S Apricot-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the current CODEOWNERS entries:

@Apricot-S
@Nihisil

do not work as intended, because CODEOWNERS requires each line to start with a path pattern.
Without a pattern, these lines are ignored by GitHub.

If the intention is to assign both users as code owners for all files, please update it to:

* @Apricot-S @Nihisil

Reference:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@Nihisil
Copy link
Contributor Author

Nihisil commented Feb 20, 2026

Interesting that GH says that file is valid:
image

but I changed it as you suggested

@Nihisil Nihisil requested a review from Apricot-S February 20, 2026 02:23
@Apricot-S Apricot-S merged commit 4733c94 into master Feb 20, 2026
9 checks passed
@Apricot-S Apricot-S deleted the add-codeowners branch February 20, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants