Repository navigation
feat: add pnpm support - #26
Merged
Merged
Conversation
verifyx detects whether a project uses npm or pnpm and uses that manager: verify:* and test scripts run with it, `verifyx init` installs devDependencies with it, and the generated agent docs name its commands. npm projects behave as before. The manager comes from devEngines.packageManager, then packageManager, then lockfiles, nearest directory first. On pnpm, init requires 11.26+ or 12.4+ and declines skott's unneeded @parcel/watcher build.
pleb
force-pushed
the
feat/pnpm-support
branch
from
October 21, 2026 06:10
b530c11 to
1f0ba5e
Compare
pleb
marked this pull request as ready for review
October 21, 2026 08:17
robdmoore
reviewed
Oct 21, 2026
robdmoore
approved these changes
Oct 21, 2026
The field only affects pnpm, and pnpm's own term for blocking a build script is "deny". Rewrite its comment around the skott example so it says why init denies @parcel/watcher's build on pnpm 11+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
verifyx detects whether a project uses npm or pnpm and uses that manager: scripts run with
pnpm run,verifyx initinstalls withpnpm add, and the generated agent docs saypnpm verify. npm projects behave as before.Why
verifyx hardcoded npm, which fails in pnpm repos: npm refuses to run scripts when
devEnginesnames pnpm, and cannot install intocatalog:orworkspace:dependencies.How
The manager comes from
devEngines.packageManager, thenpackageManager, then lockfiles, nearest directory first. On pnpm, init requires 11.26+ or 12.4+ and declines skott's unneeded@parcel/watcherbuild, which pnpm 11+ otherwise fails on in every later install.Notes
A fresh init with every check fails
unused-codebecause knip flagsskottandjscpdinignoreDependencies; this predates the branch and is left for a follow-up.Testing
Installed the packed tarball in clones of four existing projects and compared against published 1.3.0.
init(default,--defaults-only, all checks),upgrade-docs,verifylocally, in CI and failingverifylocally, in CI and failing,upgrade-docsinitwith the@parcel/watcherdecline, frozen install, re-run,verifyfrom root and sub-packageverifylocally, in CI and failing,upgrade-docs