Add loggin server 33#42
Open
hasanMasalha wants to merge 12 commits into
Open
Conversation
9 tasks
ayaabb
force-pushed
the
add-loggin--server-33
branch
from
2274143 to
db701f3
Compare
yishain11
suggested changes
Aug 6, 2024
yishain11
left a comment
yishain11
left a comment
Contributor
There was a problem hiding this comment.
- change the folder name. what is _pac?
- look for logging packages or configurations that do all this size calculations for you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logging added I believe I need to do some changes I need your feedback please