Allow multi-flag parameters#146
Open
akhoury6 wants to merge 2 commits intoManageIQ:masterfrom
Open
Conversation
Some tools need to allow the repeated input of certain valueless parameters. One such example is the use of `v` for `verbose`, where the addition of more v's increases the verbosity of the output. This behavior can be seen in tools such as curl and ssh.
Prior to this change, when the `:multi` option was passed in to a `:flag` or `:boolean` parameter, the parser would return either a a `true` value or an empty array depending on if the flag was passed in the command line or not.
After this change, the `:flag` with `:multi` set will instead count the number of times the flag was passed. Flag options without `:multi` set still exhibit the original behavior of simple `true`/`false` values.
Example config:
```ruby
opts = Optimist::options do
opt :verbose, "Enables verbose output. Twice will enable very-verbose output", multi: true
end
```
Before change:
```
$ mytool
{:verbose => []}
$ mytool -vvv
{:verbose => true}
```
After change:
```
$ mytool
{:verbose => 0}
$ mytool -vv
{:verbose => 3}
```
Contributor
Author
|
Just a few moments, I'll have the tests sorted out. Forgot about them. |
Contributor
Author
|
The remaining failures seem to be unrelated, and are the same failing tests as in the other PR that I submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tools need to allow the repeated input of certain valueless parameters. One such example is the use of
vforverbose, where the addition of more v's increases the verbosity of the output. This behavior can be seen in tools such as curl and ssh.Prior to this change, when the
:multioption was passed in to a:flagor:booleanparameter, the parser would return either a atruevalue or an empty array depending on if the flag was passed in the command line or not. This is an unusual paradigm and provides no extra functionality over regular:flagparameters.After this change, the
:flagwith:multiset will instead count the number of times the flag was passed. Flag options without:multiset still exhibit the original behavior of simpletrue/falsevalues.Example config:
Before change:
After change: