Improve variability formula generality#271
Open
stemangiola wants to merge 21 commits into
Open
Conversation
the 2D plot will take the raw parameters for the non normalised
…r mean-variability regression. Replace 'prec_coeff' with 'prec_intercept' and 'prec_slope' parameters across relevant functions and Stan models. Update tests to reflect changes in parameter names and ensure compatibility with new structure.
…ntercept parameters based on design specifications. Update Stan model to reflect intercept-centered priors for the first column and zero-centered priors for others, improving flexibility in handling variability associations.
…. Added missing commas in `plot_1D_intervals` and `plot_2D_intervals` documentation. Clarified description of `residuals_unconstrained` in `sccomp_calculate_residuals` to specify the calculation method and added details on residuals computation on both proportion and unconstrained scales.
…ssion, streamlining the parameterization and reducing complexity in the model specification.
…solidating intercepts into a single array structure. Update initialization logic in model fitting to accommodate bimodal associations and streamline loading of Stan models by preferring local sources. Enhance documentation for model loading function to clarify parameter usage.
…` function for visualizing cell-group proportions. Update `plot.sccomp_tbl` to utilize quosures for improved data handling and streamline the integration of significance thresholds in scatterplots. Add detailed documentation for the new plotting function, including parameters and return values.
… checks in `test-plot.R`. Introduce a new helper function to correctly extract captions from patchwork plots, ensuring accurate validation of Bayesian FDR labels in plot outputs.
…gy with "raw" for clarity. Update data handling and parameter filtering to reflect this change, ensuring consistency across plotting outputs and significance checks.
Introduce a new internal function `get_variability_to_composition_map` to match variability design columns to composition design columns based on their names. Implement error handling for missing terms in the mapping. Update the Stan model to incorporate the new mapping and adjust the model calculations accordingly. Add comprehensive tests to validate the mapping functionality and ensure robustness against missing terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.