Skip to content

Fix detect_deletions disable gating and harden timeout handling#333

Open
tomerh2001 wants to merge 1 commit intoManiMatter:devfrom
tomerh2001:fix-detect-deletions-timeout-resilience
Open

Fix detect_deletions disable gating and harden timeout handling#333
tomerh2001 wants to merge 1 commit intoManiMatter:devfrom
tomerh2001:fix-detect-deletions-timeout-resilience

Conversation

@tomerh2001
Copy link
Copy Markdown

@tomerh2001 tomerh2001 commented Feb 28, 2026

Summary

  • Fix detect_deletions gating so disabled jobs do not start folder watchers (main.py now checks .enabled).
  • Add JobParams.__bool__ so object truthiness consistently reflects job enabled state.
  • Add configurable global HTTP timeout via general.request_timeout (and env REQUEST_TIMEOUT) instead of a hardcoded 15s timeout in make_request.
  • Add runtime error boundaries so request failures in ARR/download-client job groups are logged and the main loop keeps running instead of crashing.
  • Update docs/example config for request_timeout and add regression tests.

Why

Validation

  • python3 -m pytest -q
  • python3 -m pylint main.py src/job_manager.py src/utils/common.py src/settings/_general.py src/settings/_jobs.py src/settings/_user_config.py tests/jobs/test_job_manager.py tests/settings/test_general.py tests/settings/test_jobs.py tests/utils/test_common.py

@AverageCakeSlice
Copy link
Copy Markdown

Can we please get this merged? Would like to use V2 but this timeout issue is preventing me from connecting to my qbittorrent instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants