Validate malformed noul criteria on /v1/systemone - #11
Merged
Merged
Conversation
Owner
|
Thank you. Reproduced on b44b4c9, and the fix is right: the spec for noul criteria is a map or null, so rejecting other values with 422 before any forward pass is what we want. Merged; it will be in 1.2.2. |
Mapika
added a commit
that referenced
this pull request
Sep 24, 2026
…ning exit status - scripts/train.sh sets pipefail; scripts/run_full.sh writes FULL_RUN_DONE only on success (fixes #14) - scripts/stage_release.py also stages mps_ops and mps_moe, which the engine loads on MPS - changelog for #11 and #13, version 1.2.2 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejects malformed noul/bool criteria with a field-specific validation response. Regression tests verify HTTP 422 before forwarding.
Checks: focused suite 44 passed; git diff --check passed. Full suite: 160 passed, 2 skipped; 4 CUDA-related assertion/memory failures remain.
Closes #10.