Conversation
|
Looks good. However, I don't have any php tools anymore on my pc (since I'm not developing in php anymore). I asked in issue #28 if someone could lcheck this. 👍 Otherwise I will get some php tools on my pc, however, could take a week or two. |
|
Are the namespace changes really compatible back to Symfony 2.8? I would imagine they are not and a new major library release is necessary at which point now incompatible Symfony versions need to be dropped. |
|
Unfortunately, my PR is wrong and it is no longer compatible with old version of Symfony - latest supported version may be ATM we are using it with Symfony 5.0 and it works OK (we are using fork), so I don't have much time for testing - I will try to fix this on weekend, but I can't promise anything ;) |
|
@advancingu We at least have an open issue to remove support for <= 3.2. @mleczakm What does your fork look like? In the linked issue they said they just added |
|
@kobelobster there are more changes required (all of them are provided in current PR) to get it working |
|
Okay, what I could imagine would be this. The currently maintained Symfony versions are 3.4, 4.4 and 5.0 https://symfony.com/releases 3.4 will be in security mode starting near end of 2020 and only receive security fixes. Although, a few questions, maybe you could answer them 😊👍 ?
So, this would leave us with this
Note: If the interfaces don't work on 4.4 I would say we create 3.0.0 with 4.4 support (without the adjusted namespaces) and then create a new branch Thoughts? |
No description provided.