[fix] add webm extension for safari#32
Open
flyinprogrammer wants to merge 1 commit intoMarconLP:mainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
Oh yeah, this is a major breaking change - because people with existing videos would need to migrate those videos to have extensions. 🤷 I don't know what to do about that; worse yet, I am useless when coding Typescript, but I imagine some re-tries or a migration script could work. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that viewing videos in Safari was broken when I ran this with AWS S3 as a backend. I came across this blog, added
.webmextensions to the videos, and 🎉 - this seemed to fix it. I have no idea if this fixes it for Backblaze, but this may be helpful.Maybe this closes: #12, maybe not.
Proof: