Skip to content

Conversation

@gerteck
Copy link
Member

@gerteck gerteck commented Dec 14, 2025

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Related to #2073

Anything you'd like to highlight/discuss:

Adds documentation in the developer guide that summarizes the discussion in "Standardize and document steps wrt to GitHub teams and PR review procedure" issue.

  • Teams to allow for easy way to request mass PR reviews.
  • Simple documentation for how to update GitHub teams and for maintainence.

I think automating with GH Actions or other tools at this point is not needed, as the number of team members are quite small.

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Update docs for GitHub Teams Management


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.61%. Comparing base (051170b) to head (58523f5).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2753   +/-   ##
=======================================
  Coverage   60.61%   60.61%           
=======================================
  Files         130      130           
  Lines        7170     7170           
  Branches     1503     1503           
=======================================
  Hits         4346     4346           
  Misses       2761     2761           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gerteck
Copy link
Member Author

gerteck commented Dec 15, 2025

image

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for managing GitHub Teams within the MarkBind organization. It provides a structured approach to organizing contributors based on their experience and responsibilities, supporting the project's goal of streamlining PR reviews and team management.

Key changes:

  • Adds a new "Managing GitHub Teams" section to the project management documentation
  • Introduces a three-tier team structure (Maintainers, Developers, Contributors) with clear role definitions
  • Provides a visual contributor journey flowchart using Mermaid to illustrate progression paths
  • Includes maintenance guidelines for keeping team rosters up-to-date

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gerteck gerteck merged commit fe2e1b9 into MarkBind:master Dec 15, 2025
17 checks passed
@gerteck gerteck deleted the doc/teamManagement branch December 15, 2025 04:19
@github-actions
Copy link

@gerteck Each PR must have a SEMVER impact label, please remember to label the PR properly.

@gerteck
Copy link
Member Author

gerteck commented Dec 15, 2025

Didn't realize mermaid diagrams were not enabled in dev guide...

#2756 to remove it for now.

@gerteck gerteck added the r.Patch Version resolver: increment by 0.0.1 label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant