Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The context mechanism is consistently integrated across both hosts and has focused coverage for its key behaviors.
Review effort: Balanced
Findings: None
What changed in this PR
Adds opt-in, per-script API bindings so injected extensions can retain isolated file-path context.
Changes:
- Introduces script-context factories and proxied
MarkEdit/requirebindings. - Wraps injected scripts with script-local contexts.
- Adds Swift and TypeScript coverage for isolation, caching, escaping, and Quick Look.
| File | Description |
|---|---|
MarkEditCore/Tests/EditorUserAssetTests.swift |
Tests generated script bindings and Quick Look behavior. |
MarkEditCore/Sources/EditorUserAsset.swift |
Injects script-local context bindings. |
CoreEditor/test/scriptContext.test.ts |
Tests context isolation and shared APIs. |
CoreEditor/src/scriptContext.ts |
Implements context factories and proxies. |
CoreEditor/src/@types/global.d.ts |
Declares the global context factory. |
CoreEditor/index.ts |
Exposes context creation to injected scripts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cyanzhong
added a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a way to isolate script executions for MarkEdit-app/extensions#54.