Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several conversions document nonexistent arguments or omit useful API references.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 5
Open (5)
What changed in this PR
Converts Browser library argument documentation from tables to structured argument lists without changing runtime behavior.
Changes:
- Migrates keyword and library initialization argument documentation.
- Reflows long descriptions and links.
- Preserves argument defaults and usage guidance.
| File | Description |
|---|---|
Browser/browser.py |
Converts library initialization docs. |
Browser/keywords/assertion_formatter.py |
Converts formatter argument docs. |
Browser/keywords/browser_control.py |
Converts browser-control argument docs. |
Browser/keywords/clock.py |
Converts clock argument docs. |
Browser/keywords/cookie.py |
Converts cookie argument docs. |
Browser/keywords/coverage.py |
Converts coverage argument docs. |
Browser/keywords/crawling.py |
Converts crawling argument docs. |
Browser/keywords/credential.py |
Converts credential argument docs. |
Browser/keywords/device_descriptors.py |
Converts device argument docs. |
Browser/keywords/evaluation.py |
Converts evaluation argument docs. |
Browser/keywords/getters.py |
Converts getter argument docs. |
Browser/keywords/interaction.py |
Converts interaction argument docs. |
Browser/keywords/locator_handler.py |
Converts locator-handler argument docs. |
Browser/keywords/network.py |
Converts network argument docs. |
Browser/keywords/pdf.py |
Converts PDF argument docs. |
Browser/keywords/playwright_state.py |
Converts lifecycle and state argument docs. |
Browser/keywords/promises.py |
Converts promise argument docs. |
Browser/keywords/runonfailure.py |
Converts failure-handler argument docs. |
Browser/keywords/strict_mode.py |
Converts strict-mode argument docs. |
Browser/keywords/waiter.py |
Converts waiting argument docs. |
Browser/keywords/webapp_state.py |
Converts storage argument docs. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Snooz82
force-pushed
the
feature/arg_docs
branch
from
September 23, 2026 13:38
6f12346 to
1e6c8af
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
converted all docs to new argument doc format.
Fixes #5267