[Improvement] Overview tab stays filtered to a single project after navigating back from Dashboard

[MatheusAssisNeves]

Thanks @timdegroot1996 , or should I say Tim the G.O.A.T. 🐐, for the quick fix in #328. The project-card → Dashboard filter now works exactly as expected.

There's a follow-up edge case though:

Description

Clicking a project card on the Overview page correctly pre-selects that project's run/tag filter and switches to the Dashboard tab (as fixed in #327 / #328). However, if you then click back to the Overview tab, the same single-project filter is still applied, so the Overview page (project cards, "Latest Runs", "Total Statistics") now only shows the one project you filtered to, instead of all projects.

Steps to reproduce

1. Open a dashboard with multiple projects (run tags or run names).
2. On the Overview tab, click a project card (e.g. project_1) → correctly navigates to Dashboard, filtered to project_1.
3. Click the Overview menu tab again.

Actual behavior

Overview still only shows project_1, the other project cards are gone/filtered out.

Expected behavior

Navigating back to the Overview tab should reset/ignore the project filter and show all projects again, since "show an overview of everything" is the whole point of that tab. The filter should only apply to Dashboard/Compare/Tables until explicitly changed or cleared by the user.

Notes for whoever picks this up

update_menu() in menu.js calls setup_data_and_graphs() → setup_filtered_data_and_filters() on every menu switch, including back to Overview, so the selectedTagSetting/selectedRunSetting pre-filter set by set_filter_show_current_project() (in graph_creation/overview.js) is still in effect when prepare_overview() re-runs. Likely fix: clear the filter (or skip re-applying it) when switching to menuOverview, similar to how clear_all_filters() is called before setting it on the way into Dashboard.

Related

Follow-up to #327 / #328.

[timdegroot1996]

This makes a lot of sense indeed. I will get to this and implement it as described!

[timdegroot1996]

Fixed in #350, implemented as described.

Navigating back to the Overview tab now drops the single project filter that was applied by clicking a project card, so all projects are shown again. The project the card applied is remembered, and on the way back it is only cleared while the filter modal still holds exactly that filter — so anything you changed by hand on the Dashboard in the meantime survives the navigation. The version filter is cleared only when the same navigation set it (the version badge on a card).

Two robot tests cover it: one asserts the overview is back to all 18 runs and every project section after returning, the other asserts a hand-picked run tag filter is still in place after the same navigation.