feat: open filter dropdowns upwards when there is no room below (#361) - #362
Merged
Merged
Conversation
The checkbox dropdowns in the filter and settings modals always opened below their select with a fixed 50vh max-height. Near the bottom of the modal the panel stretched the modal, a scrollbar appeared and the page jumped. A shared set_filter_dropdown_visible helper now measures the viewport space above and below the select when a panel opens: it flips the panel above the select when it does not fit below and there is more room above, and caps its height to the space on the chosen side. The five duplicated open/close handlers use it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Running the example build to eyeball a change overwrote the committed example/ files. With --test the dashboard and database are only built in the repo root (gitignored). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
timdegroot1996
added a commit
that referenced
this pull request
Sep 26, 2026
Changelog entry for #362 and example dashboard/database regenerated so the committed example carries the upward-opening filter dropdowns. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
timdegroot1996
added a commit
that referenced
this pull request
Sep 26, 2026
* Release 2.4.0 Bump version.py, setup.py and the CLI version fixture to 2.4.0, regenerate example/robot_dashboard.html and example/robot_results.db from the current source, and add the 2.4.0 CHANGELOG section. * Release 2.4.0: include filter dropdown flip (#362) Changelog entry for #362 and example dashboard/database regenerated so the committed example carries the upward-opening filter dropdowns. * docs(skills): release skill — tag after merge, GitHub Release, manual docs deploy deploy.yml no longer runs on tag pushes, so the docs build started by the release merge usually runs before the tag exists. Document the order: tag the merge commit, create the GitHub Release, then re-run the deploy with workflow_dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #361
Problem
The checkbox dropdowns in the filter modal (Filter Profiles, Run Tags, Versions, custom filters like Pipeline/Release) and the settings modal (hidden custom filters) always opened below their select with a fixed
max-height: 50vh. Opening one near the bottom of the modal stretched the modal, added a scrollbar and made the page jump.Root cause
The
.filterCheckBoxespanels are custom absolute-positioned elements (not Bootstrap dropdowns, so no Popper flip). Nothing checked the available viewport space when a panel opened.Fix
set_filter_dropdown_visible(select, panel, visible)injs/filter/controls.js. When a panel opens it measures the viewport space below and above the select:.drop-up) when there is more room above;get_filter_dropdown_placement..drop-upusesbottom: 100%, so an upward panel stays attached to its select and shrinks towards it while searching.filter_modal.js×3,modal_options.js,settings_modal.js) now use the helper.Also included:
scripts/example.py --test(andscripts\example.bat --test) builds the example dashboard in the repo root without overwriting the committedexample/files, useful for checking a change by eye. Documented in CLAUDE.md, CONTRIBUTING.md and the dev-workflow skill.Tests
tests/javascript/filter_dropdown.test.jscovers the placement decision: fits below, flips up, stays down, caps at the space above, very long lists, minimum height. JS suite: 18 files, 358 tests passed.🤖 Generated with Claude Code