Skip to content

Refactored method to reduce cognitive complexity #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cormacdalton merged 2 commits into from
Sep 10, 2025
Merged

Refactored method to reduce cognitive complexity #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
180fba5
Refactored method to reduce cognitive complexity
VivekKumar97 Aug 29, 2025
2146894
added error message according to expecations
VivekKumar97 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 32 additions & 26 deletions src/main/java/com/mastercard/developer/encryption/EncryptionConfigBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,34 +54,40 @@ static byte[] sha256digestBytes(byte[] bytes) throws NoSuchAlgorithmException {
}

void checkJsonPathParameterValues() {
for (Map.Entry<String, String> entry : decryptionPaths.entrySet()) {
if(entry.getKey().contains("[*]") || entry.getValue().contains("[*]")){
if(!(entry.getKey().contains("[*]") && entry.getValue().contains("[*]"))){
throw new IllegalArgumentException("JSON paths for decryption with wildcard must both contain a wildcard!");
}
if((entry.getKey().split("[*]", -1).length-1 > 1 || entry.getValue().split("[*]", -1).length-1 > 1)){
throw new IllegalArgumentException("JSON paths for decryption with can only contain one wildcard!");
}
} else {
if (!JsonPath.isPathDefinite(entry.getKey()) || !JsonPath.isPathDefinite(entry.getValue())) {
throw new IllegalArgumentException("JSON paths for decryption must point to a single item!");
}
}
decryptionPaths.forEach((key, value) -> validatePaths(key, value, "decryption"));
encryptionPaths.forEach((key, value) -> validatePaths(key, value, "encryption"));
}

private void validatePaths(String key, String value, String action) {
boolean keyHasWildcard = key.contains("[*]");
boolean valueHasWildcard = value.contains("[*]");
if (keyHasWildcard || valueHasWildcard) {
validateBothOrNoneHasWildcard(keyHasWildcard, valueHasWildcard, action);
validateSingleWildcardOnly(key, value, action);
} else {
validateDefinitePaths(key, value, action);
}
}

for (Map.Entry<String, String> entry : encryptionPaths.entrySet()) {
if(entry.getKey().contains("[*]") || entry.getValue().contains("[*]")){
if(!(entry.getKey().contains("[*]") && entry.getValue().contains("[*]"))){
throw new IllegalArgumentException("JSON paths for encryption with wildcard must both contain a wildcard!");
}
if((entry.getKey().split("[*]", -1).length-1 > 1 || entry.getValue().split("[*]", -1).length-1 > 1)){
throw new IllegalArgumentException("JSON paths for encryption with can only contain one wildcard!");
}
} else {
if (!JsonPath.isPathDefinite(entry.getKey()) || !JsonPath.isPathDefinite(entry.getValue())) {
throw new IllegalArgumentException("JSON paths for encryption must point to a single item!");
}
}
private void validateBothOrNoneHasWildcard(boolean keyHasWildcard, boolean valueHasWildcard, String action) {
if (!(keyHasWildcard && valueHasWildcard)) {
throw new IllegalArgumentException("JSON paths for " + action + " with wildcard must both contain a wildcard!");
}
}

private void validateSingleWildcardOnly(String key, String value, String action) {
if (countWildcards(key) > 1 || countWildcards(value) > 1) {
throw new IllegalArgumentException("JSON paths for " + action + " with can only contain one wildcard!");
}
}

private void validateDefinitePaths(String key, String value, String action) {
if (!JsonPath.isPathDefinite(key) || !JsonPath.isPathDefinite(value)) {
throw new IllegalArgumentException("JSON paths for " + action + " must point to a single item!");
}
}

private int countWildcards(String path) {
return path.split("\\[\\*]", -1).length - 1;
}
}