Repository navigation
Conversation
| | **1.9.2** | 3.8, 3.9, 3.10, 3.11, 3.12 | Previous | Maintenance & security fixes | | ||
| | **1.10.0** | 3.8, 3.9, 3.10, 3.11, 3.12, 3.13 | Current | Adding support for Python 3.13 | |
There was a problem hiding this comment.
I don't think we need to mention the two 1.x.x versions here ? This table was probably added because we were planning a 2.0.0, which won't happen now.
But we can use this table to state that python versions less than 3.11 are not supported and that only >= 3.11 are actively supported
There was a problem hiding this comment.
I think its nice addition to have current and previous versions in the table for glancing.
Also we are still keeping support for <=3.11 in the library. If you think the wording doesn't convey this I can try make it more explicit
There was a problem hiding this comment.
The only real problem I see is that we can't go on updating or adding entries to this table every time we make a patch or update the lib version.
The Notes column sounds like something that belongs in the CHANGELOG and not in the README.
Also the note Maintenance & security fixes makes me think that 1.9.2 is a separate release that's in maintenance mode, which it's not. It's been superseded by 1.10 .
I think it might be better if re-word it a bit to make it clear that the current version supports 3.13.
Anything beyond that sounds overkill to me
There was a problem hiding this comment.
- Simplified the table to current release
- Dropped the notes column in favour of maintainability (in-depth changes redirected to changelog)
- Changed table column name for clarity
| @@ -1,5 +1,20 @@ | |||
| # Changelog | |||
|
|
|||
| ## [1.10.0] - 2026-10-XX (TODO UPDATE) | |||
There was a problem hiding this comment.
Note to update this when we publish the new version.
| 'Programming Language :: Python :: 3.6', | ||
| 'Programming Language :: Python :: 3.7', | ||
| 'Programming Language :: Python :: 3.8', | ||
| 'Programming Language :: Python :: 3.9', | ||
| 'Programming Language :: Python :: 3.10', |
There was a problem hiding this comment.
Can you check if these should be removed as well ?
I think these show up as info on the PyPi page, and we should probably drop these.
I'm not 100% sure here, so pls check before we remove it.
There was a problem hiding this comment.
We should keep these, all the major Python libraries have them.
There was a problem hiding this comment.
sorry I was referring to removing versions 3.6-3.10, not removing the entire list. We've dropped support for them, so I'm not sure if we should keep them here.
There was a problem hiding this comment.
The library is still compatible with 3.8, 3.9 and 3.10, that is why I kept them in the supported versions/classifiers.
We have just mentioned that we wont providing additional ongoing support/fixes for them, but library will still work with those versions.
I have removed 3.6 and 3.7 as they were not compatible and remove already.
Description
tests_requirefrom setup.pyTesting/Validation
All tests are passing and on top of this additional testing against a live API was done covering both supported algorithms and the different integration methods offered. Packaging also shows no issues and reflects new constraints.