Skip to content

Fix TabControl issue where tabs (in a dialog) stopped working #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolaihenriksen wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

Fix TabControl issue where tabs (in a dialog) stopped working #4065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/MaterialDesignThemes.Wpf/Behaviors/Internal/TabControlHeaderScrollBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,13 +336,14 @@ private void AssociatedObject_ScrollChanged(object sender, ScrollChangedEventArg
return;
if ( _isAnimatingScroll || _desiredScrollStart is not { } desiredOffsetStart)
return;
if (!TabControl.IsHitTestVisible)
return;

double originalValue = desiredOffsetStart;
double newValue = e.HorizontalOffset;
_isAnimatingScroll = true;

// HACK: Temporarily disable user interaction while the animated scroll is ongoing. This prevents the double-click of a tab stopping the animation prematurely.
bool originalIsHitTestVisibleValue = TabControl.IsHitTestVisible;
TabControl.SetCurrentValue(FrameworkElement.IsHitTestVisibleProperty, false);

AssociatedObject.ScrollToHorizontalOffset(originalValue);
Expand All @@ -355,8 +356,8 @@ private void AssociatedObject_ScrollChanged(object sender, ScrollChangedEventArg
_desiredScrollStart = null;
_isAnimatingScroll = false;

// HACK: Set the hit test visibility back to its original value
TabControl.SetCurrentValue(FrameworkElement.IsHitTestVisibleProperty, originalIsHitTestVisibleValue);
// HACK: Re-enable hit test visibility
TabControl.SetCurrentValue(FrameworkElement.IsHitTestVisibleProperty, true);
};
AssociatedObject.BeginAnimation(TabControlHeaderScrollBehavior.CustomHorizontalOffsetProperty, scrollAnimation);
}
Expand Down
Loading