compute: Use less-quadratic half_join2 from differential-dataflow PR #706#35796
Merged
antiguru merged 5 commits intoMaterializeInc:mainfrom Apr 2, 2026
Merged
compute: Use less-quadratic half_join2 from differential-dataflow PR #706#35796antiguru merged 5 commits intoMaterializeInc:mainfrom
antiguru merged 5 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
frankmcsherry
force-pushed
the
patch_dd_706
branch
from
cc4362c to
bbdc52d
Compare
antiguru
force-pushed
the
patch_dd_706
branch
2 times, most recently
from
d9447b4 to
492e539
Compare
…aterializeInc#706 Patch differential-dataflow and differential-dogs3 to frankmcsherry's `half_join_ordered` branch, which introduces a new `half_join2` operator that avoids quadratic behavior through a two-stage pipeline. Switch the delta join implementation to use `half_join2::half_join_internal_unsafe` instead of `half_join::half_join_internal_unsafe`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Add a dyncfg flag (default true) to gate the use of half_join2 vs the original half_join in delta join rendering. This provides an escape hatch to revert to the old implementation if issues arise with the new less-quadratic half_join2 operator. Register the flag in parallel-workload's FlipFlagsAction and mzcompose's UNINTERESTING_SYSTEM_PARAMETERS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
frankmcsherry
approved these changes
Apr 2, 2026
Contributor
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
Looks good here; appreciate the feature flag!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
differential-dataflowanddifferential-dogs3to frankmcsherry/differential-dataflow#706 (half_join_orderedbranch), which introduces ahalf_join2operator that avoids quadratic behavior through a two-stage pipeline.half_join_internal_unsafecalls from thehalf_joinmodule to the newhalf_join2module.Test plan
cargo check -p mz-computepasses🤖 Generated with Claude Code