Skip to content

<fix>[sugonSdn]: sync tf ports after ping#4566

Closed
MatheMatrix wants to merge 2 commits into
zsv_5.1.0from
sync/taiyue.chen/ZSV-12357
Closed

<fix>[sugonSdn]: sync tf ports after ping#4566
MatheMatrix wants to merge 2 commits into
zsv_5.1.0from
sync/taiyue.chen/ZSV-12357

Conversation

@MatheMatrix

Copy link
Copy Markdown
Owner

Trigger TF port sync from TF controller ping success instead of MN startup. Keep the original one day interval and port cleanup algorithm, while scoping sync to the current controller.

Resolves: ZSTAC-85281

Change-Id: I84a88a34135cd47fc79b3019d2f0fc2953f06ac9

sync from gitlab !10534

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ba14aea6-5593-4ea3-b94f-c6829eb2d8bb

📥 Commits

Reviewing files that changed from the base of the PR and between 49a2020 and f5333e7.

⛔ Files ignored due to path filters (1)
  • conf/springConfigXml/sugonSdnController.xml is excluded by !**/*.xml
📒 Files selected for processing (5)
  • plugin/sugonSdnController/src/main/java/org/zstack/sugonSdnController/controller/SugonSdnController.java
  • plugin/sugonSdnController/src/main/java/org/zstack/sugonSdnController/controller/neutronClient/TfPortClient.java
  • plugin/sugonSdnController/src/main/java/org/zstack/sugonSdnController/network/TfPortService.java
  • plugin/sugonSdnController/src/main/java/org/zstack/sugonSdnController/network/TfZstackPortSync.java
  • test/src/test/groovy/org/zstack/test/integration/network/sdnController/SugonSdnControllerCase.groovy
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/taiyue.chen/ZSV-12357

Comment @coderabbitai help to get the list of available commands.

@MatheMatrix MatheMatrix force-pushed the sync/taiyue.chen/ZSV-12357 branch from 91380ea to 8158b93 Compare July 14, 2026 10:24
shixin.ruan and others added 2 commits July 14, 2026 18:57
Trigger TF port sync only after TF controller ping succeeds.
Keep the one day interval, cleanup limit, and controller scoped sync.

Resolves: ZSTAC-85281
Related: ZSV-12357
Change-Id: I84a88a34135cd47fc79b3019d2f0fc2953f06ac9
Related: ZSV-12357
Change-Id: If07dce918c4d7d9f62445184ff5984e30b83ce64
@MatheMatrix MatheMatrix force-pushed the sync/taiyue.chen/ZSV-12357 branch from 8158b93 to f5333e7 Compare July 14, 2026 10:58
@MatheMatrix MatheMatrix deleted the sync/taiyue.chen/ZSV-12357 branch July 15, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants