Refactor Rules part 2#1867
Merged
Merged
Conversation
rocky
force-pushed
the
Rule-refactor-part2
branch
3 times, most recently
from
July 20, 2026 14:17
813fe18 to
cab693e
Compare
mmatera
reviewed
Jul 20, 2026
rocky
commented
Jul 20, 2026
|
|
||
|
|
||
| class Association(Builtin): | ||
| class Association_(Builtin): |
Member
Author
There was a problem hiding this comment.
In the next PR there will be a mathics.core.atoms.association.Association class. I thought I had stashed away the changes, but this one bleeds through.
rocky
force-pushed
the
Rule-refactor-part2
branch
from
July 20, 2026 14:40
cab693e to
61e7b9c
Compare
Member
Author
|
After this PR, I'll move on to Association. Then I'll come back and make another round in Rules, if for no other reason, to remove the evaluation parameter on BaseRule objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More Python linting around Rules.
Better document the weirdnesses around our Python Rules code.