Skip to content

chore: housekeeping#263

Merged
MatteoGabriele merged 2 commits into
MatteoGabriele:mainfrom
graphieros:vue-data-ui-3.22.11
Jul 17, 2026
Merged

chore: housekeeping#263
MatteoGabriele merged 2 commits into
MatteoGabriele:mainfrom
graphieros:vue-data-ui-3.22.11

Conversation

@graphieros

@graphieros graphieros commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

A bit of housekeeping:

  • bump vue-data-ui to latest
  • attempt to correct the dynamic width of lab heatmap charts which cells were stretching too much when new weeks were added. Use a fixed width base to account for label width, and keep the dynamic aspect based on the number of weeks.

Summary by CodeRabbit

  • Bug Fixes

    • Improved heatmap sizing so layouts render more consistently across different time ranges.
  • Improvements

    • Updated the charting component dependency to improve compatibility and stability.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5144c834-70e4-434b-a19b-437452bae340

📥 Commits

Reviewing files that changed from the base of the PR and between 1328ceb and f843e68.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • app/components/Chart/GlobalEventsHeatmap.vue
  • package.json

📝 Walkthrough

Walkthrough

Updates the heatmap width calculation to use a fixed base and per-week contribution, and upgrades the vue-data-ui dependency from ^3.22.9 to ^3.22.11.

Changes

Heatmap sizing

Layer / File(s) Summary
Chart dependency update
package.json
Updates the vue-data-ui dependency to ^3.22.11.
Heatmap width calculation
app/components/Chart/GlobalEventsHeatmap.vue
Changes the layout width formula to 43 + numberOfWeeks.value * 32.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: matteogabriele

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is generic and does not describe the dependency bump or heatmap sizing change. Use a concise title that names the main change, such as 'Bump vue-data-ui and adjust heatmap width calculation.'
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

color: colors.value.textMuted,
layout: {
width: numberOfWeeks.value * 43,
width: 43 + numberOfWeeks.value * 32,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messy magic numbers, I know, but it's the lab^^

@MatteoGabriele MatteoGabriele left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatteoGabriele
MatteoGabriele merged commit 7b7ae29 into MatteoGabriele:main Jul 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants