feat: Open all devices in same directory using their Names as folder names#107
Merged
feat: Open all devices in same directory using their Names as folder names#107
Conversation
MaxG87
force-pushed
the
copilot/update-open-functionality
branch
from
10dccf9 to
45281ee
Compare
MaxG87
force-pushed
the
copilot/update-open-functionality
branch
4 times, most recently
from
0e557b9 to
2329198
Compare
MaxG87
force-pushed
the
copilot/update-open-functionality
branch
2 times, most recently
from
e72ca46 to
2be9680
Compare
If a user is able to write to /, the mkdir based test would fail to reject that. BREAKING-CHANGE: Names that form absolute paths are rejected to avoid bad surprises when using ButterBackup.
MaxG87
force-pushed
the
copilot/update-open-functionality
branch
from
2be9680 to
faaf04b
Compare
This is a desperate attempt to fix a bug in the unmount path. This didn't work in a first try but seems to be acceptable.
…y with error handling Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/23d2a9a9-70b1-4f5d-9d34-699123bebba2 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/23d2a9a9-70b1-4f5d-9d34-699123bebba2 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
This will allow a new way of operation. `open` will open the device to a static directory, e.g. `/mnt/My_Device`, so it is reliably there. For a better overview, the mountpoint should remain.
MaxG87
force-pushed
the
copilot/update-open-functionality
branch
from
faaf04b to
82d982f
Compare
Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/c83949e8-d63d-42fb-a260-7556bf9dce81 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
MaxG87
force-pushed
the
copilot/update-open-functionality
branch
from
82d982f to
9f54b40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.