Ask for the anonymized file, and give shared links a preview - #5
Merged
Merged
Conversation
An issue form. The page tells people to download the anonymized copy and open an issue, and nothing on the GitHub side asked for it -- or warned against the raw export, which carries a name, a biometric profile, a watch serial and the exact time of the swim. The warning is the first thing in the form, above the upload box rather than below it, and it says out loud that the repository is public. It also asks how the lap button is used, which is the project's central ambiguity rather than a form-filling courtesy: nothing in a file distinguishes "many phantom turns" from "a different lapping habit", the `lap-structure` finding exists precisely because the data cannot settle it, and the swimmer is the only one who knows. The site's "open an issue" link now goes to issues/new/choose so the form is actually reachable from it. Open Graph tags, so a shared link is a card rather than a bare URL. Absolute URLs because a crawler resolves them with no document base. A committed PNG rather than the SVG banner, because no major crawler renders SVG for a preview card -- and pre-rendered, so the typeface is baked in and does not depend on the machine that produced it. It needed a flat background rather than the banner's gradient: the gradient encoded to 303 kB, over the 256 kB ceiling the added-large-files hook enforces, and flat comes to 38 kB. No CSP change: og.png is same-origin, which `img-src 'self'` already allows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue form
The page tells people to download the anonymized copy and open an issue — and nothing on the GitHub side asked for it, or warned against the raw export. A raw Garmin export carries a name, weight, height, resting heart rate, a watch serial and the exact time of the swim.
So the warning is the first thing in the form, above the upload box rather than below it, and it says out loud that the repository is public.
It also asks how you use the lap button. That isn't form-filling courtesy — it's the project's central ambiguity. Nothing in a file distinguishes "many phantom turns" from "a different lapping habit"; the
lap-structurefinding exists precisely because the data cannot settle it, and the swimmer is the only one who knows. AGENTS.md says as much.The site's "open an issue" link now points at
issues/new/choose, so the form is actually reachable from where people are told to go.Link previews
Open Graph tags, so a shared link renders as a card instead of a bare URL.
check-added-large-filesenforces. Flat comes to 38 kB.No CSP change was needed:
og.pngis same-origin, which the existingimg-src 'self'already covers. I checked rather than assumed.Also done, outside this diff
Topics are now set on the repo (
gh repo edit): addedgarmin-connect,forerunner,pool-swimming,javascript,zero-dependencies,client-side,vibe-codingto the existing four.The social preview still needs you. GitHub's social preview image cannot be set through the API or
gh— it's Settings → General → Social preview, andweb/og.pngin this PR is exactly the 1280×640 asset to upload there.Verification
check-yaml(the repo's own prek hook) passes on the formog.pngserves from the built site at 200, andbuild-web.mjspicks it up with no change, sinceweb/is copied wholesaletask check: 79 tests, lint, privacy scan, build🤖 Generated with Claude Code