FDMAP-1349: Decouple Repositories & Build New Docker Images#2
Open
omarfq-maxar wants to merge 2 commits intomainfrom
Open
FDMAP-1349: Decouple Repositories & Build New Docker Images#2omarfq-maxar wants to merge 2 commits intomainfrom
omarfq-maxar wants to merge 2 commits intomainfrom
Conversation
- .python-version: Simplify from virtualenv name to version number (3.10.9) for Docker build compatibility - backends.py: Add redirect_uri to auth_complete_params for OAuth token exchange, required by Login.gov OIDC provider. Add info-level logging for authentication flow debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Dockerfile for Container-Native Deployment
Overview
This PR introduces a production-ready Dockerfile and comprehensive documentation for openmaps-auth, enabling container-native deployment to Kubernetes. This is part of the broader OpenMaps modernization initiative to migrate from legacy RPM-based deployments to modern Docker + Helm + Kubernetes architecture.
Changes
New Files
Dockerfilepython:3.10-slimauth:auth(UID/GID 999)Key Features:
docs/DOCKER_BUILD.mdComprehensive documentation covering:
Deployment
Build & Push to ECR (already done)
Kubernetes Deployment
The image is deployed via the openmaps Helm chart with:
/healthendpointConfiguration
Required Environment Variables
Integration with MapEdit
The auth service integrates with MapEdit for session-based authentication:
/auth/login/auth/callback/auth/validateendpointSecurity Improvements
auth:authuser (UID/GID 999)Testing
Local Testing
Health Check
curl http://localhost:8080/health # Expected: {"status": "healthy"}Migration Notes
Version Tagging
2024.01.15-1.el9(RPM-based)0.8.14(Semantic versioning)Deployment Target
vantormaps-dev(dev),vantormaps-stg(staging),vantormaps-prod(production)Checklist
Breaking Changes
None. This PR only adds new files and does not modify existing application code.
Backward Compatibility
The Dockerfile is designed to work with the existing Flask application without any code changes. The application continues to support the same authentication flows and API endpoints.