Skip to content

Align config schema folder defaults with scaffold runtime #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavgautam01 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

Align config schema folder defaults with scaffold runtime #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ workspace:
- configs
- fixtures
- exports
- pipeline

connectors:
- name: ledger-sandbox
Expand Down
2 changes: 1 addition & 1 deletion src/maxed_cli/schemas/config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"description": "Sub-folders to create under the workspace root.",
"items": { "type": "string", "minLength": 1 },
"uniqueItems": true,
"default": ["workpapers", "configs", "fixtures", "exports"]
"default": ["workpapers", "configs", "fixtures", "exports", "pipeline"]
}
}
},
Expand Down
8 changes: 8 additions & 0 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
load_document,
validate_config_file,
)
from maxed_cli.scaffold import DEFAULT_FOLDERS
from maxed_cli.schemas import CONFIG_SCHEMA, load_schema

VALID = {
"version": 1,
Expand Down Expand Up @@ -42,6 +44,12 @@ def test_valid_config_yaml(tmp_path: Path) -> None:
assert validate_config_file(cfg).ok


def test_schema_folder_default_matches_scaffold_default() -> None:
schema = load_schema(CONFIG_SCHEMA)
default = schema["properties"]["workspace"]["properties"]["folders"]["default"]
assert default == DEFAULT_FOLDERS


def test_missing_required_field(tmp_path: Path) -> None:
bad = {"version": 1, "workspace": {"root": "./ws"}}
cfg = _write(tmp_path / "c.json", bad)
Expand Down