Skip to content

Make smoke JSON output consistent#6

Open
abhinavgautam01 wants to merge 1 commit into
Maxed-OSS:mainfrom
abhinavgautam01:fix/smoke-json-output-consistency
Open

Make smoke JSON output consistent#6
abhinavgautam01 wants to merge 1 commit into
Maxed-OSS:mainfrom
abhinavgautam01:fix/smoke-json-output-consistency

Conversation

@abhinavgautam01

Copy link
Copy Markdown

Summary

Fixes #3 by making maxed smoke --json use the shared JSON emitter consistently across success paths.

Both the no-connectors path and connectors path now include a top-level ok field and use deterministic pretty-printed JSON formatting.

Changes

  • Route no-connectors smoke --json output through _emit_json()
  • Route connectors smoke --json output through _emit_json()
  • Add top-level ok to smoke --json success payloads
  • Add regression tests for connector and no-connector JSON output

Validation

  • pytest -q
  • git diff --check
  • maxed --version
  • maxed suite --json
  • maxed init examples/workspace.yaml --base-dir /tmp/maxed-cli-smoke-json-ci --json
  • maxed lint-workpaper /tmp/maxed-cli-smoke-json-ci/example-workspace/workpapers/example.workpaper.json
  • Package build
  • Built wheel install + maxed --version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

smoke --json Output Inconsistencies

1 participant