Scripts to watch the evolution of generated files#23
Open
gilles-peskine-arm wants to merge 5 commits intoMbed-TLS:mainfrom
Open
Scripts to watch the evolution of generated files#23gilles-peskine-arm wants to merge 5 commits intoMbed-TLS:mainfrom
gilles-peskine-arm wants to merge 5 commits intoMbed-TLS:mainfrom
Conversation
gilles-peskine-arm
added
enhancement
gilles-peskine-arm
force-pushed
the
trace_generated_files
branch
from
1800e86 to
37a0f24
Compare
Archive the evolution of generated files over a range of revisions. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This is especially useful to continue from a previous series of commits that are already traced. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Useful when the traced files are checked into Git, or when they're generated by some shell command (-r) rather than make. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
In case the make command doesn't have correct dependencies, make sure that it at least regenerates the targets. This isn't enough if intermediate files need to be updated as well, but it's the best we can do here. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
bjwtaylor
reviewed
Mar 12, 2026
| # it's the best we can do here. If make doesn't have correct | ||
| # dependencies, make sure to delete all relevant intermediate files | ||
| # in the run_before command. | ||
| for filename in files: |
Contributor
There was a problem hiding this comment.
Does this block need to account for if the --build-dir argument is used and remove the files relative to this directory, rather than the current one?
| subprocess.check_call(['git', 'diff', '--quiet']) | ||
| except subprocess.CalledProcessError: | ||
| raise UncommittedChangesException() | ||
| self.initial_revision = subprocess.check_output( |
Contributor
There was a problem hiding this comment.
Does this need to account for the scenario when we are in detached head?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archive the evolution of generated files over a range of revisions.