Add SSL log validator script#296
Open
gilles-peskine-arm wants to merge 7 commits intoMbed-TLS:mainfrom
Open
Conversation
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
When two clients connect to the same server, validate that they get distinct server_random values and distinct ephemeral public keys. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
If the data from `MBEDTLS_SSL_DEBUG_BUF` that's listed in text form after the hex digits starts with two bytes that happen to be hex digits, this could be interpreted as an extra pair of hex digits. Fix this. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
gilles-peskine-arm
added
needs-review
6 tasks
bjwtaylor
previously approved these changes
Apr 8, 2026
| if 'DHM: GY' in client_log.dumps: | ||
| values = client_log.dumps['DHM: GY'] | ||
| else: | ||
| values = client_log.dumps['server ephemeral public key'] |
There was a problem hiding this comment.
If I've understood correctly I believe this will abort if the lookup fails as no matches are present, is this the desired behavior or should it return a validation failure?
Contributor
Author
There was a problem hiding this comment.
Good idea, I'll return a more informative and non-fatal validation failure.
| def main() -> int: | ||
| """Command line entry point.""" | ||
| parser = argparse.ArgumentParser(description=__doc__) | ||
| parser.add_argument('--list-tasks', |
There was a problem hiding this comment.
Do you need to add action='store_true', action='store_false', or nargs=0, argparse to avoid the error "error: argument --list-tasks: expected one argument" here?
bjwtaylor
reviewed
Apr 8, 2026
gilles-peskine-arm
removed
the
needs-reviewer
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
…f the key is not found Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Don't require the file and task arguments when `--list-tasks` is passed. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
bjwtaylor
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a script
scripts/validate_ssl_logs.pyto validate logs fromssl_client2andssl_server2. Useful for testing things that we can't test from within a single run of a test programs. Use this to check that when two clients connect to the same server, the connections use different random values.PR checklist