fix: crafting station picking wrong recipe#165
Open
DerekChan65535 wants to merge 1 commit into
Open
Conversation
Author
|
@McJty Are you going to review it? Or I would prefer to close this PR since it opens for too long. |
Collaborator
|
As this is on 1.12 I'm not going to merge this anymore. For me 1.12 development is dead |
Author
|
Ok thx |
Collaborator
|
I will check this out soon |
DerekChan65535
force-pushed
the
1.12
branch
from
d4eab7c to
6f9f038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix an bug that crafting station picking wrong recipe.
Bug details:
As a minecraft player
WHEN In the crafting station, item A and item B has same name, and meta data
AND item A has no NBT data but B has NBT data
AND item B is right after item A
WHEN I request item B
THEN findItem will give the index of item A since A has no NBT data
AND crafting station will send craft request with item A
Change tested. Issue fixed.