Skip to content

[NEW] Listening to the connect_error event #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yannickl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[NEW] Listening to the connect_error event #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5128778
[ADD] `connect_error` callback method
yannickl Oct 30, 2014
939db5d
[UPDATE] Bump to version 1.2.0
yannickl Oct 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SocketIO/Source/SIOSocket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ typedef NSArray SIOParameterArray;

// Event responders
@property (nonatomic, copy) void (^onConnect)();
@property (nonatomic, copy) void (^onConnectError)(NSDictionary *errorInfo);
@property (nonatomic, copy) void (^onDisconnect)();
@property (nonatomic, copy) void (^onError)(NSDictionary *errorInfo);

Expand Down
6 changes: 6 additions & 0 deletions SocketIO/Source/SIOSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ + (void)socketWithHost:(NSString *)hostURL reconnectAutomatically:(BOOL)reconnec
if (weakSocket.onConnect)
weakSocket.onConnect();
};

socket.javascriptContext[@"objc_onConnectError"] = ^(NSDictionary *errorDictionary) {
if (weakSocket.onConnectError)
weakSocket.onConnectError(errorDictionary);
};

socket.javascriptContext[@"objc_onDisconnect"] = ^() {
if (weakSocket.onDisconnect)
Expand Down Expand Up @@ -98,6 +103,7 @@ + (void)socketWithHost:(NSString *)hostURL reconnectAutomatically:(BOOL)reconnec
};

[socket.javascriptContext evaluateScript: @"objc_socket.on('connect', objc_onConnect);"];
[socket.javascriptContext evaluateScript: @"objc_socket.on('connect_error', objc_onConnectError);"];
[socket.javascriptContext evaluateScript: @"objc_socket.on('error', objc_onError);"];
[socket.javascriptContext evaluateScript: @"objc_socket.on('disconnect', objc_onDisconnect);"];
[socket.javascriptContext evaluateScript: @"objc_socket.on('reconnect', objc_onReconnect);"];
Expand Down
4 changes: 2 additions & 2 deletions SocketIO/Source/socket.io.js.h
View file
Open in desktop

Large diffs are not rendered by default.